human-essentials
human-essentials copied to clipboard
[Bug] Inventory imports should prevent modifying already-existing inventory
Summary
The inventory import should be a safe operation for initial Essentials Bank location setup. Prevent importing if the location already has ANY inventory.
Why Fix
Reduction in new bank confusion. Of the banks that have imported inventory, about half have done it multiple times with confusing results.
Details
1/ When you import inventory, it should set the current inventory to be the level that is imported.
Importing inventory adds a positive adjustment in the amount imported.
New Information
Examples of ways that imports can go wrong before this fix:
- If you double-click, you get doubled values.
- If you open up the new storage location in two different tabs, you can import twice -- (CL thinks that's what happened in the latest case -- ITRC, the line items did not match between the two times, and it was 20 minutes apart)
Criteria for completion
- [ ] Import CSV button disabled after clicking
- [ ] For Storage Location Import, check after the button is clicked and give an error if the storage location already has ANY inventory
- [ ] Importing inventory results in each item in the imported inventory having the inventory level specified in the import.
- [ ] Tests to demonstrate this behavior
Hey, i can work on this
This issue has been inactive for 243 hours (10.13 days) and will be automatically unassigned after 117 more hours (4.88 days).
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
Automatically unassigned after 7 days of inactivity.
I'd like to take this on.
Go for it!
Automatically unassigned after 7 days of inactivity.
Still working on this, could I get reassigned? My time got away from me a bit.
You certainly can!
Automatically unassigned after 7 days of inactivity.
Could I get reassigned again? Got unassigned again. Not sure why this time since I had activity.
Yeah -- it's not smart enough to look at the associated PR. Will reassign.