Florent Chatterji comments

Results 22 comments of


                                            Florent Chatterji

Improve test coverage by writing more tests

I added a PR with some tests. I think I could go further and add more tests, but this seems to be a good start

WIP disallow entering numbers with commas

hi @cielf , no unfortunately its tests regularly failing, because of changes made here. i'll try to debug in the next few days

prevent multiple imports of inventory

@dorner ok, what I did was prevent importing when there are already items in the inventory. So whenever an import is made, it is made on an empty inventory. So...

prevent multiple imports of inventory

ok gotcha, the PR is ready for review

prevent multiple imports of inventory

Hey, so i adjusted the PR for a new review. As discussed on slack, i left the inventory already has items error.

prevent multiple imports of inventory

@dorner No worries, i understand. So what remains to be done on this ticket? Just removing the split_difference?

[Bug] Inventory imports should prevent modifying already-existing inventory

Hey, i can work on this

Improve test coverage

@compwron sorry had to close the previous PR and open this one (the other one was created from my main branch by mistake)

Improve synchronization of items and their kits -- active status

Hey, I'd like to work on this issue if possible :)

Improve synchronization of items and their kits -- active status

Hey @dorner @cielf , I checked the code. As the kit status and item status must always be the same, I would propose keeping just one database field, the item...