Felipe Duarte

Results 23 comments of Felipe Duarte

@mike-donald would you be able to add a unit test at the `sample` module that demonstrates the issue? Since it's related to data binding it would be great to see...

Interesting! This is reproducible by changing line 24 of `paparazzi-gradle-plugin/src/test/projects/verify-rendering-modes/src/test/java/app/cash/paparazzi/plugin/test/RenderingModesTest.kt` to `(0..25)` from `(0..2)`.

Found it, this is due to every screenshot to be limited to a 1000px, either width or height: https://github.com/cashapp/paparazzi/blob/eb60debfd74975c8dd6b4a240f1c81c09dfd689e/paparazzi/src/main/java/app/cash/paparazzi/Paparazzi.kt#L93 Current implementation won't give you pixel perfect snapshots, I don't have...

Hi @sdoward, we discussed internally. Screenshots are limited to avoid the repo size to grow exponentially (if you use git LFS) and for making the HTML report easier to visualize....

@sdoward thanks for detailed explanation. I imagined it was for verification with designers ;) We'll have to discuss it internally to consider this as a feature enhancement. As always, PRs...

I did a small refactoring at #526 so that in the future we want to handle scaled/non-scaled images we have only one source.

We might have a hard time to solve this one since latest version at time of writing -- https://mvnrepository.com/artifact/com.android.tools/sdk-common/30.4.0-alpha08 -- still have vulnerabilities in two dependencies.

> Note that all of those vulnerabilities are patched in the corresponding latest libs @TWiStErRob yeah, I saw this, it's great! > So maybe exposing newer versions of those transitive...

@costular thanks for reporting! Could you take a look on `paparazzi-gradle-plugin/src/test/projects` and see if you can provide a testing sample that mimics your issue?

@magnusvs thanks for reporting! I tried to reproduce your issue with the current codebase and wasn't able to. Here's what I did: 1. On file `paparazzi-gradle-plugin/src/test/projects/custom-fonts-xml/src/main/res/font/cashmarket_medium.xml`, I removed all references...