Florian Bourgey

Results 28 comments of Florian Bourgey

Hello, I am working on it.

I updated the following https://github.com/fbourgey/pandas/blob/feature-plot-weighted-kde/pandas/plotting/_core.py#L1449 https://github.com/fbourgey/pandas/blob/feature-plot-weighted-kde/pandas/plotting/_matplotlib/hist.py#L266 The code works. Should we add one example in the function `kde` with the parameter `weights`? Does this [function](https://github.com/fbourgey/pandas/blob/feature-plot-weighted-kde/pandas/plotting/_matplotlib/hist.py#L287) need to be updated as...

The following code gives ```python s = pd.Series([1, 2, 2.5, 3, 3.5, 4, 5]) ax = s.plot.kde() ``` ![Figure_0](https://github.com/user-attachments/assets/d0513d48-8e20-4a29-8a52-5c84383663d4) Replacing with some `weights` produces ```python weights = pd.Series([0.1, 0.0, 0.0,...

@mroeschke should everything be rewritten using `finalize` then?

@mroeschke, @WillAyd, I tried using `__finalize__` instead. What do you think?

@WillAyd @mroeschke, any chance I could get an update?

@mroeschke I suggested something. I kept some checks for attrs in `_cmp_method` and `_arithm_method` in `pandas/core/frame.py`

> From the preview link I don't think this did anything: > > https://pandas.pydata.org/preview/pandas-dev/pandas/59549/docs/reference/api/pandas.DataFrame.index.html > > May also just be because these items are class attributes and not properties. >...

@WillAyd @mroeschke Ideally, do we want the source link to point to [this](https://github.com/pandas-dev/pandas/blob/v2.2.2/pandas/core/frame.py#L12546C1-L12563C6) or as Will said as `DataFrame.columns` has no code, there is no need to have a source...