Francis Bogsanyi
Francis Bogsanyi
It happens because we're not checking parameters here: https://github.com/open-telemetry/opentelemetry-ruby/blob/659be35520552779e605915094a7b5b0ad376ceb/sdk/lib/opentelemetry/sdk/trace/span.rb#L69-L82 or here: https://github.com/open-telemetry/opentelemetry-ruby/blob/659be35520552779e605915094a7b5b0ad376ceb/sdk/lib/opentelemetry/sdk/trace/span.rb#L272-L280. #207 is a slightly stagnant PR attempting to address this.
> So I think my preference would be to ignore and log to `DEBUG` 👍 I think that's good for now. I will be working to improve our error handling...
> Sorry for no activity here. I'll work on a fix, but there's also another problem that I've found - it will also fail when the value can't be mapped...
I think #1136 is relevant here.
The initial PR is #108 , however I don't believe @rdooley has time to continue with this and the PR likely needs significant updates to account for drift in the...
Note also https://github.com/open-telemetry/opentelemetry-specification/pull/768 adds clarity around requirements here.
Pushing this out until https://github.com/open-telemetry/opentelemetry-specification/pull/768 is approved.
A compatibility shim is required by the spec, although that requirement is implicit for now. There’s a tracking issue here: https://github.com/open-telemetry/opentelemetry-specification/issues/1174
The implementation was stale and the author was no longer working on it. He agreed we should close it. It is still something we'd like to have but no one...
I'm mildly terrified by this proposal. Accessing another thread's thread locals seems fraught with problems, and it is pretty violating too. I need to 🤔 about this more. Some initial...