opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Implement OpenTracing compatibility shim

Open fbogsany opened this issue 5 years ago • 10 comments

fbogsany avatar Sep 16 '19 16:09 fbogsany

👋 I'm your huckleberry.

Self link https://github.com/open-telemetry/opentelemetry-java/tree/master/opentracing_shim

rdooley avatar Sep 16 '19 21:09 rdooley

The initial PR is #108 , however I don't believe @rdooley has time to continue with this and the PR likely needs significant updates to account for drift in the API. I've removed the assignment & opened this up to other folks who might like to help out.

fbogsany avatar Sep 21 '20 19:09 fbogsany

Note also https://github.com/open-telemetry/opentelemetry-specification/pull/768 adds clarity around requirements here.

fbogsany avatar Sep 21 '20 19:09 fbogsany

The initial PR is #108 , however I don't believe @rdooley has time to continue with this and the PR likely needs significant updates to account for drift in the API. I've removed the assignment & opened this up to other folks who might like to help out.

That is exactly correct. Thank you for removing my assignment.

rdooley avatar Sep 21 '20 20:09 rdooley

Pushing this out until https://github.com/open-telemetry/opentelemetry-specification/pull/768 is approved.

fbogsany avatar Sep 22 '20 14:09 fbogsany

@fbogsany What's the real-world justification for this? Who is only supporting OpenTracing but not OpenTelemetry?

johnnyshields avatar Dec 06 '20 13:12 johnnyshields

A compatibility shim is required by the spec, although that requirement is implicit for now. There’s a tracking issue here: https://github.com/open-telemetry/opentelemetry-specification/issues/1174

fbogsany avatar Dec 07 '20 02:12 fbogsany

@fbogsany I am a bit confused. This issue has been open since 2019 and it was labeled as good first issue. Then there was a PR, which you closed in favor of a new implementation, which did not exist and still does not exist.

Are you going to implement this, since it is a good first issue and also mentioned that this was a req by the spec?

tessus avatar Oct 26 '21 19:10 tessus

The implementation was stale and the author was no longer working on it. He agreed we should close it. It is still something we'd like to have but no one is actively working on it.

fbogsany avatar Oct 26 '21 21:10 fbogsany

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

github-actions[bot] avatar Apr 28 '24 01:04 github-actions[bot]