Finn Bacall
Finn Bacall
I've seen this test fail a few times in the past, would be good to work out what is causing it. https://github.com/seek4science/seek/actions/runs/3106803528/jobs/5034135515 ``` --seed 41671 ``` ``` AuthLookupTableTest#test_deletes_records_when_assets_removed: NoMethodError: undefined...
Spaces in tool name: ```json { "value": "GA4GH Beacon", "reftype": "bio.tools" } ``` ...the actual bio.tools ID is `GA4GH_Beacon` Comma-separated tools: ```json { "value": "graphclust, GraphClust2", "reftype": "bio.tools" } ```...
Also the "Download" and "Raw" buttons return an empty file.
https://github.com/seek4science/seek/actions/runs/4265338078/jobs/7424544654#step:16:31 postgres unit tests `--seed 31755` ``` Failure: DynamicTableHelperTest#test_Should_return_the_dynamic_table_columns_and_rows [/home/runner/work/seek/seek/test/unit/helpers/dynamic_table_helper_test.rb:61] Minitest::Assertion: Expected: false Actual: true ``` https://github.com/seek4science/seek/blob/536d93b946ce1fd4addd09a09e0786c469bb5004/test/unit/helpers/dynamic_table_helper_test.rb#L61
When extracting samples from a spreadsheet, using a sample type with a "SEEK strain" attribute, SEEK should attempt to recognize the strain from the title, not just the database ID....
It's confusing to the user to see the serialized ruby hash e.g.: ![image](https://github.com/seek4science/seek/assets/503373/c58d43bd-d076-4c47-b1f8-3f7f203ec127)
https://git-lfs.com/ SEEK should support Git LFS for storing large files using the Git storage backend. 1. Install Git LFS: https://github.com/git-lfs/git-lfs/blob/main/INSTALLING.md 2. Configure the LFS "endpoint" to something like `file://path-to-seek-home-directory/filestore/git/lfs`. 3....
...whereas new versions do. e.g. if I select "v0.3.4" as the tag on the initial registration, the version will be called "Version 1". ![image](https://github.com/seek4science/seek/assets/503373/cfb4b8aa-2832-4fc8-a5cf-dd74e287ca70)
Possibly introduced with Workflow RO-Crate submission API - there are persisted git annotations with a null value for `git_version_id`. This was detected because the uniqueness validation was failing: ``` validates...
...when a workflow only has one version. When the workflow has multiple versions and the dropdown menu appears, it is fine. Example: ![image](https://github.com/seek4science/seek/assets/503373/5d871d23-e4fe-4f97-9edc-ddb789909bf1) ![image](https://github.com/seek4science/seek/assets/503373/f58c5a3e-aa77-4b6f-b6b9-7de52008828a)