Brian Faust

Results 91 comments of Brian Faust

@ryanio updated your post with links to PRs that enable some of the rules

Enabling the `@typescript-eslint/strict-boolean-expressions` rule with a strict config is quite a headache in the current state of the repository because of the `isTruthy` and `isFalsy` functions and the mixed use...

What I mean by mistake is that generally `null` and `undefined` mean the same thing and people mostly argue semantics that `undefined` means _uninitialised_ and `null` means _currently_ unavailable but...

@ryanio I tried to enable [require-await](https://eslint.org/docs/rules/require-await) but it has tons of false positives like the below code where `this.get` will return a `Promise` but because the call isn't awaited it...

@holgerd77 [no-sparse-arrays](https://eslint.org/docs/rules/no-sparse-arrays) doesn't result in any changes yet and I remember you said we should only add rules that result in an actual change. Does that still stand?

`@typescript-eslint/strict-boolean-expressions` would be the biggest remaining rule, after that only smaller ones. Opened a [separate issue](https://github.com/ethereumjs/ethereumjs-monorepo/issues/2137) for that due to the complexity of the task.

`no-sparse-arrays` is actually already included via the `eslint:recommended` config that is being extended.

@holgerd77 I think we can close this. I enabled all requested rules and extracted the bigger ones into separate issues I'll tackle.

@jasonmccreary I'll work on a PR for this on the weekend based on the `meta` property.

@jasonmccreary are there any specific ones that you think would be a good start?