Brian Faust

Results 91 comments of Brian Faust

The `pnpm-workspace.yaml` file is just the basic template and `turbo` does indeed stop every single time, just not deterministically at the same point, which makes it a bit of a...

The execution time seems fairly consistent, give or take 1 second. I'm not sure if it's relevant but the project has various native module dependencies like https://github.com/bcoin-org/bcrypto and also various...

> Just thought that this collides a bit with the trie library inheritance structure we have atm since this pruned Trie will likely (?) not be a checkpointed one (and...

I'm not sure if adding more and more options is really the right way. The constructors and options are already fairly complex. Wouldn't composition make a lot more sense? Then...

For now I think adding an option is fine, was more talking long-term. Don't have any concrete snippet at hand for the trie package but the gist of it is...

@holgerd77 Took a look at a few packages over the last days and moving them to a more functional approach is quite an undertaking so this should probably be something...

I'll work on a more functional-style PoC for the Trie library as I find time over the next weeks so that could maybe serve as a foundation for planning further...

@jochem-brouwer what do you estimate how long this would take once you tackle it? Saw that assigned the hours effort label.

I would probably keep the decorators for another major release and go with an option for now unless a subclass is required to keep it maintainable due to the complexity....

1. I have a branch somewhere that swapped out the hashing functions to use https://github.com/bcoin-org/bcrypto which was a lot faster than noble because it uses native C functions. Will check...