Faradawn Yang

Hi Kalyan, Thank you for the detailed feedback! I have removed the uncessary comments and fixed init.py. Regarding the use of fixture in pytest, I was following sentence_transformer's pytest structure,...

Hi Dhrubo, Thanks for checking the PR! Will work on it more by fixing the lint and unit tests! Thanks, Faradawn ________________________________ From: Dhrubo Saha ***@***.***> Sent: Tuesday, December 5,...

Hi @mingshl, Thank you for the careful review. I have made changes to the function descriptions, e.g. optional parameters, accordingly. Hi @dhrubo-os, I have checked CodeCov's result and added unit...

Got it, Dhrubo. I will fix the following lint issue. ``` nox > black --check --target-version=py38 setup.py noxfile.py opensearch_py_ml/ utils/ tests/ would reformat /home/runner/work/opensearch-py-ml/opensearch-py-ml/opensearch_py_ml/ml_models/question_answering_model.py would reformat /home/runner/work/opensearch-py-ml/opensearch-py-ml/tests/ml_models/test_question_answering_pytest.py ```

Hi @dhrubo-os, Thanks for checking! I have added a missing package in requirement-dev.txt, added to CHANGELOG file, and fixed formating issues. On my Mac, I only know `pytest` and `nox...

Hi @dhrubo-os, the failing integration test is fixed. There are 4 worklows awaiting approval. If there is anything I can do, please let me know.

### [2023-10-11] Hi, I would like to tackle this issue. I plan to create a similiar script called distilbert model besides Sentence Transformer: ``` opensearch-py-ml/opensearch_py_ml/ml_models/sentencetransformermodel.py opensearch-py-ml/opensearch_py_ml/ml_models/distilbertmodel.py ``` Specifically, I plan...

Hi @dhrubo-os, Got it -- make sense! Will 1) create a question_answering.py model, and 2) raise PR in that branch! Thanks, Faradawn