Fantix King comments

Results 216 comments of


                                            Fantix King

Expose uv_loop_t pointer for integration with other C-extensions

Thanks for the PR and sorry for the delay! I think having an int pointer in Python doesn't make much sense - it'll be used in a C context anyways,...

Expose uv_loop_t pointer for integration with other C-extensions

> * Is there a new `uvloop` release on the horizon that includes this feature? ;) Yes, we'll try to release a new version in the next week or two....

Expose uv_loop_t pointer for integration with other C-extensions

> > * Any words of caution concerning `libuv` API compatibility? > > Hmm we should probably re-export some of [the libuv version-checking utils](https://docs.libuv.org/en/v1.x/version.html) if we're statically linking, @1st1 wdyt?...

Add test for preexec_fn fd double close issue

@graingert may I ask for a review pls?

Add test for preexec_fn fd double close issue

Close in favor of #481

create_subprocess_exec should treat env={} as empty environment (#439)

I'm not sure why the new test is failing on the CI? It works locally for me. Other than that, I think this is okay, thanks for the PR!

create_subprocess_exec should treat env={} as empty environment (#439)

Dropped an assertion under debug mode that ensures cstring array must not be empty.

Version bump of cibuildwheel

Thanks for the PR! This is already done now and musl wheels are built successfully in my latest test, will be included in the next release.

`_SSLProtocolTransport.close()` cannot close the connection until timeout or EOF

Sorry for the late reply! With a quick look through the details (thanks @Rongronggg9 for the debugging!), this is probably because the remote peer didn't reply a proper TLS `close_notify`....

python3.10 build issues due to deprocations in py3.10

As we're already building on 3.11, I'm closing this one now, but feel free to repoen if issue persists.