uvloop icon indicating copy to clipboard operation
uvloop copied to clipboard

Version bump of cibuildwheel

Open WAKayser opened this issue 3 years ago • 2 comments

Update cibuildwheel to 2.2.0, which will enable musllinux wheel builds. This is useful for environments like alpine linux containers.

WAKayser avatar Oct 23 '21 10:10 WAKayser

Thanks for taking care of this @WAKayser. I landed here after wondering why my uvloop installs were still so slow on Alpine Linux.

Cross-referencing the related PR MagicStack/uvloop#435 reviewed by @fantix. Would appreciate a review here as well.

Happy to help, if there's any way I can help move this forward.

br3ndonland avatar Jun 11 '22 18:06 br3ndonland

I believe further changes are needed here.

There's currently a workaround for cffi wheels, invoking yum.

# This is needed for now because cffi has no cp310 wheels
CIBW_BEFORE_ALL_LINUX: "yum -y install libffi-devel"

Running this command on Alpine would obviously fail, so it must be changed. One option could simply be checking if yum exists as part of the command. Another option would be using cibuildwheel's override mechanism (toml-only, added quite recently IIRC,):

[[tool.cibuildwheel.overrides]]
select = "*-manylinux*"
before-all = "yum -y install libffi-devel"

While this is actually unnecessary now, as cffi has cp310 wheels, adding cp311 will re-introduce this requirement. cffi also has no musllinux wheels, but it seems like the default image already has libffi-dev.

Might also be worth upgrading cibuildwheel to the latest version. It will change from manylinux2010 to manylinux2014 so if it's not desired an image would need to be set explicitly.

I would love to see musl wheels too, let me know if I can help :) CC @elprans @fantix

ben9923 avatar Jun 27 '22 21:06 ben9923

Thanks for the PR! This is already done now and musl wheels are built successfully in my latest test, will be included in the next release.

fantix avatar Sep 11 '22 19:09 fantix