Fantix King

Results 216 comments of Fantix King

Cool, thanks for the PR and sorry for the late reply! I'm also suggesting the following changes on your branch: ```patch diff --git a/src/gino/dialects/asyncpg.py b/src/gino/dialects/asyncpg.py index 795f8d9..f329e69 100644 --- a/src/gino/dialects/asyncpg.py...

The current (Dec 2018) GINO implementation of SQLAlchemy engine is different comparing to vanilla SQLAlchemy engine over DB-API. Vanilla SQLAlchemy calls `cursor.execute()` before creating `ResultProxy`, but GINO shall create a...

@tng10 This PR should at least make sqltap run. But if you use `first()`, `scalar()`, `prepare()`, `iterate()` or "executemany", the row count may be less than expected. Would that be...

Okay good to know! Let's get this merged and address the rest in a new issue. Thanks for the info!

I think we do use `sslmode` in the DSN URL? https://github.com/MagicStack/asyncpg/blob/075114c195e9eb4e81c8365d81540beefb46065c/asyncpg/connect_utils.py#L308-L311 Is it the `ssl` parameter in the Python method signature of `asyncpg.connect()` (not the DSN URL string) you were...

Sorry, I was in a move in the last few days and everything is a bit messy. I Will take a look this weekend. Thanks for the PR!

How about just `orm.Product.load(brand=orm.Brand)`? It'll set `orm.Brand` instances on `Product.brand` for you. If you really want to leverage the loader system to serialize the rows directly, you may want to...

Hmm the `reflect()` was not supposed to work - it was probably a bad idea to simply inherit and expose such SQLAlchemy sync methods without specification, but that ship has...

Thanks for all the comments! As SQLAlchemy 1.4 is going to have [experimental support](https://docs.sqlalchemy.org/en/14/orm/extensions/mypy.html) on typing, let's try to include native typing support in GINO 1.4 (likely the next major...

Right, #36 also mentioned (in zh) that the init hooks are not called. I'll try to make an easier setup for testing with Sanic.