fanquake

consensus: Better document ComputeMerkleRoot & add test for return value

3

At least twice we've had attempts to refactor [`ComputeMerkleRoot`](https://github.com/bitcoin/bitcoin/blob/fd69ffbbfb3e08b474b33540e56cf4f81e5c21d4/src/consensus/merkle.cpp#L45) (#22046 & #22046). While the value of any sort of refactor is dubious, it may also come with subtle, unintended side-effects,...

ci: feature_proxy failing in MSVC job

2

https://github.com/bitcoin/bitcoin/actions/runs/7219794888/job/19671475361?pr=29088#step:27:73: ```bash 288/288 - feature_proxy.py failed, Duration: 2410 s stdout: 2023-12-15T08:53:02.026000Z TestFramework (INFO): PRNG seed is: 197024891591373016 2023-12-15T08:53:02.026000Z TestFramework (INFO): Initializing test directory D:\a\_temp\test_runner_₿_🏃_20231215_084456\feature_proxy_168 2023-12-15T09:33:11.259000Z TestFramework (ERROR): Assertion failed Traceback...

test: failure in rpc_getdescriptorinfo.py (OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted)

5

https://cirrus-ci.com/task/5258208494223360: ```bash 238/246 - rpc_getdescriptorinfo.py failed, Duration: 1 s stdout: 2022-08-01T13:12:51.831000Z TestFramework (INFO): Initializing test directory C:\Users\ContainerAdministrator\AppData\Local\Temp\test_runner_₿_🏃_20220801_121834\rpc_getdescriptorinfo_6 2022-08-01T13:12:52.490000Z TestFramework (ERROR): Unexpected exception caught during testing Traceback (most recent call last):...

failure in wallet_basic.py --descriptors

6

https://cirrus-ci.com/task/6282049166770176?logs=ci#L3112 ```bash node0 2023-03-12T18:59:07.047547Z [scheduler] [wallet/wallet.h:840] [WalletLogPrintf] [default_wallet] AddToWallet 0a94aab7b4dc8ba22b88ccd6b2c9898936c7d36bf8b3e1789f6083b85f6d752a new test 2023-03-12T18:59:07.053000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 134, in main self.run_test() File...

ci: wallet_listtransactions.py --legacy-wallet failure

10

https://github.com/bitcoin/bitcoin/actions/runs/6082441277/job/16500239670" ```bash Remaining jobs: [wallet_listtransactions.py --legacy-wallet] 274/274 - wallet_listtransactions.py --legacy-wallet failed, Duration: 2686 s stdout: 2023-09-05T11:07:42.589000Z TestFramework (INFO): PRNG seed is: 4023633279228776754 2023-09-05T11:07:42.589000Z TestFramework (INFO): Initializing test directory D:\a\_temp\test_runner_₿_🏃_20230905_092624\wallet_listtransactions_222 2023-09-05T11:52:26.642000Z...

1.29.0: failure to build against libssl-dev 3.x

15

Using master at af16084341fddf29582995576a036f5525a68d98. Inside a Ubuntu Mantic container ([libssl-dev 3.0.9](https://packages.ubuntu.com/mantic/libssl-dev)). ```bash apt update && apt upgrade -y apt install gcc g++ git make patch libz-dev curl cmake python3 pkg-config...

build: compile failure with mingw-w64

3

Following the instructions on https://capnproto.org/install.html, using the master branch (f5531718b95c2ad4fcedc624e0d46866455007f4) and compiling for `mingw-w64` on Ubuntu 22.04: ```bash git clone https://github.com/capnproto/capnproto.git cd capnproto/c++ git checkout master autoreconf -i ./configure --host=x86_64-w64-mingw32...

msan: use of uninitialized value in secp256k1_scalar_mul_shift_var

4

Building master (05bfab69aef3622f77f754cfb01220108a109c91) in the following way (same flags as we use in our MSAN CI), results in the following failure: ```bash Ubuntu clang version 17.0.6 (5build1) (x86_64) ./autogen.sh ./configure...

mingw-w64: "visibility attribute not supported in this configuration; ignored" under `-flto`

5

Building master (b10ddd2bd2bdce9ca8f2d4733636a9d9e7ac3da1): ```bash # x86_64-w64-mingw32-gcc (GCC) 12-win32 ./autogen.sh ./configure --host=x86_64-w64-mingw32 CFLAGS="-flto" LDFLAGS="-flto" make -j9 src/secp256k1.c: In function 'secp256k1_context_create': src/secp256k1.c:149:1: warning: visibility attribute not supported in this configuration; ignored [-Wattributes]...

Moved from https://github.com/bitcoin/bitcoin/issues/28867. ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current behaviour It crashed ### Expected behaviour Not to crash...