fanquake

Results 616 comments of fanquake

> ZMQ is trying to link against realtime on macOS. Patched out all usage of `librt` here. Landed one related change upstream: https://github.com/zeromq/libzmq/pull/4702.

Guix Build (aarch64): ```bash 4f3beefc6f4dc2a44829697ebd14e2f1016a35372f261bd379c66190e93db745 guix-build-f684b5d7ddfe/output/aarch64-linux-gnu/SHA256SUMS.part b80ef38b4ad2a51bd033114884cb4b30e6b10675a6bfca08aa96680a7a754fc9 guix-build-f684b5d7ddfe/output/aarch64-linux-gnu/bitcoin-f684b5d7ddfe-aarch64-linux-gnu-debug.tar.gz 1c9c9198bda3419e9d49c809ef2a7e4e1c2b7846f9e03695e5175dbc7a5c0c8f guix-build-f684b5d7ddfe/output/aarch64-linux-gnu/bitcoin-f684b5d7ddfe-aarch64-linux-gnu.tar.gz 3a9b4be095aa58dd7e99494d863d4d247fff110576f78e0682d6893868543b64 guix-build-f684b5d7ddfe/output/arm-linux-gnueabihf/SHA256SUMS.part f6a0df95ce573affb505daf30b068f7baea6fdf6f489ee8cd88dd22c3f8e7f81 guix-build-f684b5d7ddfe/output/arm-linux-gnueabihf/bitcoin-f684b5d7ddfe-arm-linux-gnueabihf-debug.tar.gz 678f17eba53df3964445a8968029d41bbe6ab199eb7ce8b62ea96233bf1d6c54 guix-build-f684b5d7ddfe/output/arm-linux-gnueabihf/bitcoin-f684b5d7ddfe-arm-linux-gnueabihf.tar.gz 911e56f6d3f0e3b5d6003bd6b6c9c60c55976d03813af13bac54bffd6e282f0b guix-build-f684b5d7ddfe/output/arm64-apple-darwin/SHA256SUMS.part 4a07c8e8ffe0fb0be25bd26bd0c3e6e3b921de6eb083625bd3d5f071520f7364 guix-build-f684b5d7ddfe/output/arm64-apple-darwin/bitcoin-f684b5d7ddfe-arm64-apple-darwin-unsigned.tar.gz bb1c090b2ce12232ce7934a6f386bd23b0e14f69f0bd8e7b2adfbbca689cee15 guix-build-f684b5d7ddfe/output/arm64-apple-darwin/bitcoin-f684b5d7ddfe-arm64-apple-darwin-unsigned.zip e4304bbbd976af67ff6ba1dc1abbbc4dd0ad1dae42a6822f2cf2548b9fd8f980 guix-build-f684b5d7ddfe/output/arm64-apple-darwin/bitcoin-f684b5d7ddfe-arm64-apple-darwin.tar.gz b5732915ddfebcda4b2ec4fa5f7b5fdd88783bccd5729c1d3a64ba207806ce60 guix-build-f684b5d7ddfe/output/dist-archive/bitcoin-f684b5d7ddfe.tar.gz ef255118bf5f06508eba468c92fd0f33e1edb55db00d605ebdff2aa509aa52cc guix-build-f684b5d7ddfe/output/powerpc64-linux-gnu/SHA256SUMS.part 1fb84edc34acc73ce32017f5b916468fd86595ae36b7e952cdc5848d73e6dbea guix-build-f684b5d7ddfe/output/powerpc64-linux-gnu/bitcoin-f684b5d7ddfe-powerpc64-linux-gnu-debug.tar.gz...

Rebased, and reworked the changes here, to hopefully make them easier to review.

Rebased. Added all the missing newline/diff adjustments. Swapped CMake minimum patch to 3.22. Updated the PR reference in the Windows patch.

> I suggest passing -DCMAKE_BUILD_TYPE=None to disable this overriding, which also works with DEBUG=1. I'm not exactly sure what we want to do with build types and CMake packages in...

Guix Build (aarch64): ```bash e9a70ec7c66652aa96facc2fe3117fb177cb61e6d28fadc48893546f9cebf6cb guix-build-218e69c705d7/output/aarch64-linux-gnu/SHA256SUMS.part 0fea765c772ee00ec37d4efde6296e173a8a765792534a731e64b253effd9242 guix-build-218e69c705d7/output/aarch64-linux-gnu/bitcoin-218e69c705d7-aarch64-linux-gnu-debug.tar.gz 1689943e2b3caa664a9bb5c137ffc161252b253568b563d5a4433e2ac55174ec guix-build-218e69c705d7/output/aarch64-linux-gnu/bitcoin-218e69c705d7-aarch64-linux-gnu.tar.gz 6934a443a689d40d61fd22ed99596971e3d0d72dcb547f45e9298650410073a4 guix-build-218e69c705d7/output/arm-linux-gnueabihf/SHA256SUMS.part 6b205c30827be076573277d6741b7f798c4c66f6ab5f596416e00fc3561c3782 guix-build-218e69c705d7/output/arm-linux-gnueabihf/bitcoin-218e69c705d7-arm-linux-gnueabihf-debug.tar.gz d9e54b54890aab83a4a197f319b369c97867630040e0836a94af0d55a9965c73 guix-build-218e69c705d7/output/arm-linux-gnueabihf/bitcoin-218e69c705d7-arm-linux-gnueabihf.tar.gz 0ece588fdc72a3ba98ef6b95a0327a7ed40cf75128b121333fd0ee4b251abde8 guix-build-218e69c705d7/output/arm64-apple-darwin/SHA256SUMS.part abaeac99b9170c43ce49931b61adecabe6cc5278b1c9598baaf3bff6c6f18732 guix-build-218e69c705d7/output/arm64-apple-darwin/bitcoin-218e69c705d7-arm64-apple-darwin-unsigned.tar.gz e17bab169418a3ee3b1f3679a5b597de62b40744e13d845171c576760b1ca61c guix-build-218e69c705d7/output/arm64-apple-darwin/bitcoin-218e69c705d7-arm64-apple-darwin-unsigned.zip a92ccb4fdd1b3f89a61e890fe5670ecb2b0553841489a09c30c37c5654f236e7 guix-build-218e69c705d7/output/arm64-apple-darwin/bitcoin-218e69c705d7-arm64-apple-darwin.tar.gz 22cf0c65544a061587581caa67bb5d4a110c413ba4dc49bde9d65c03d045379a guix-build-218e69c705d7/output/dist-archive/bitcoin-218e69c705d7.tar.gz 1ce094cc2a24c62e9731af914f53d72c699e32cc43acb5e686bb01328e4ea5ac guix-build-218e69c705d7/output/powerpc64-linux-gnu/SHA256SUMS.part efbba26bac27c0e84892fab7a6a02583fe2caa346c89999b2b35a39ef88f285c guix-build-218e69c705d7/output/powerpc64-linux-gnu/bitcoin-218e69c705d7-powerpc64-linux-gnu-debug.tar.gz...

> is non-deterministic across architectures. Should be fixed now.

Rebased, and fixed an issue with the most recent push. Guix build (aarch64 & x86_64): ```bash c7aa6bd428ba4ea1c925dafe4df3505ad92e84a196b17c8cb7965d7db231e6a0 guix-build-0388ad0d65b6/output/aarch64-linux-gnu/SHA256SUMS.part 944e734a719886ec26aff12a80be67d28f2c4b7781a341894d3e2ca8477e3497 guix-build-0388ad0d65b6/output/aarch64-linux-gnu/bitcoin-0388ad0d65b6-aarch64-linux-gnu-debug.tar.gz 087ac7a0c1d87a95adacb9fa138aced37a172d4d5199fc75c64831d9f6211972 guix-build-0388ad0d65b6/output/aarch64-linux-gnu/bitcoin-0388ad0d65b6-aarch64-linux-gnu.tar.gz 3b010552293f84e98b715f844fc5d487409bdd9915b32f067109558a329878c3 guix-build-0388ad0d65b6/output/arm-linux-gnueabihf/SHA256SUMS.part ad923f9de5c2aa379a8332bc84df7273ac55bfb0f34c219064bd740000cd090d guix-build-0388ad0d65b6/output/arm-linux-gnueabihf/bitcoin-0388ad0d65b6-arm-linux-gnueabihf-debug.tar.gz 393cad9f63d37e18ab523ca6e3730195a8f07d9423f2cd681747099c8964e5d9 guix-build-0388ad0d65b6/output/arm-linux-gnueabihf/bitcoin-0388ad0d65b6-arm-linux-gnueabihf.tar.gz 8f33ab7c9769941dd42d0df1cb4495c42f0af4f66911f4b319a4d75b0ff7a27a guix-build-0388ad0d65b6/output/arm64-apple-darwin/SHA256SUMS.part...

> CMake compiles 7 fewer source files compared to Autotools. It skips:: That's expected. We aren't opting in to either of these features.

> Perhaps, it should be considered an upstream bug in configure.ac The files are compiled unconditionally, and the content is control by defines. If you look at the object files...