fanquake

Results 616 comments of fanquake

> Again, I don't understand what the goal is. The goal is to remove things we don't use. If we don't need bzip2, then I don't see a reason to...

Changed to drop the xz changes, and just switch tar.bzip2 tarballs to using tar.gz (same as release tarballs), so we can drop bzip2 as a Guix dep. > it would...

Why not put the windows change with the windows change: https://github.com/bitcoin/bitcoin/pull/29868 ? Looks like the other change could just be PR'd on it's own, and doesn't need to be based...

> fully static binaries Yea. I think I'm just going to start PR'ing related changes, so we can move forward with static builds separately from the GUI, and keep all...

Are you planning on providing the requested information here, so this can be investigated further?

Pleas stop leaving endless self review comments on PRs. It's not only unecessary, but everytime you comment here, it sends 4000 people an email. Some commentary / responding to review...

> There are no conflicts with https://github.com/bitcoin/bitcoin/pull/29865. Looks like there are now?

https://github.com/bitcoin/bitcoin/pull/29868/checks?check_run_id=24699627882: ```bash In file included from common/run_command.cpp:13: ./util/subprocess.h: In member function ‘int subprocess::Popen::wait()’: ./util/subprocess.h:1062:7: error: unused variable ‘ret’ [-Werror=unused-variable] 1062 | int ret = WaitForSingleObject(process_handle_, INFINITE); | ^~~ ```

> I assume you added https://github.com/bitcoin/bitcoin/commit/b69b9e85e98cac2c7585c9b613185dc6c80320cc because it no longer uses an external dependency? It's there because setting something that is already on, to on, is pointless, and doesn't test...