fanquake

> Any other sanitizer false-positives while we're at it? :) Anything in `test/sanitizer_suppressions/*` is up for grabs (if it can be fixed) > It would imply require getting https://github.com/bitcoin-core/crc32c-subtree/pull/6 in,...

> I think there should be no suppressions related to asm in those files I'm just talking about general suppressions, nothing asm specific.

> This now depends on #29493 Want to rebase now?

@russeree are you still following up here?

No worries. @maflcko may pick it up.

@thepowersgang fair enough. Is this something you're interested in fixing? Looks like there are ways to work around the libssl incompatiblities (although I'm not completetly sure of the ramifications of...

This still seems broken. i.e Running `--legacy-wallet` tests directly will no-longer work: ```bash test/functional/test_runner.py wallet_createwallet.py --legacy-wallet Temporary test directory at /tmp/test_runner_₿_🏃_20240214_135022 Running Unit Tests for Test Framework Modules ..................... ----------------------------------------------------------------------...

Concept NACK. I don't think we should remove test coverage from all other platforms, just to accomodate Windows. In the worse case this should just have a Windows paths with...

> We should not treat them in a discriminatory way. I don't see how fixing the tests in the way I've suggested would be discriminatory. It would make them work...

> FWIW, the [_wfopen_s](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-s-wfopen-s?view=msvc-170) function reports an error for the x modifier even in Wine. So it reports an error but the unit tests don't fail? Is this another (different...