fanquake
fanquake
cc @sipa you might have some insight here in regards to prevector.
https://github.com/bitcoin/bitcoin/pull/28687/checks?check_run_id=19528202548 ```bash /usr/bin/ccache clang++-13 -stdlib=libc++ -std=c++20 -DHAVE_CONFIG_H -I. -I../src/config -fmacro-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -DHAVE_BUILD_INFO -DPROVIDE_FUZZ_MAIN_FUNCTION -I. -I./minisketch/include -I./secp256k1/include -I./univalue/include -I./leveldb/include -isystem /ci_container_base/depends/x86_64-pc-linux-gnu/include -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION -DBOOST_NO_CXX98_FUNCTION_BASE -isystem /ci_container_base/depends/x86_64-pc-linux-gnu/include -pthread -I/ci_container_base/depends/x86_64-pc-linux-gnu/include -I/ci_container_base/depends/x86_64-pc-linux-gnu/include/ -fdebug-prefix-map=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -Wstack-protector...
> Interesting that the guix macOS build passed, given that it is on clang-15, no? I'd guess this is because our macOS SDK (libc++) is from Xcode 15, which is...
> Though, on GHA it says XCode 14.3 According to https://developer.apple.com/xcode/cpp/#c++20, "Ranges" have been available on macOS since Xcode 14.3.
> (Possibly?) fixed in https://github.com/bitcoin/bitcoin/pull/29275 Looks like it does, this compiles for me locally atleast: https://github.com/fanquake/bitcoin/tree/28687_29275. @stickies-v can you rebase this branch on top of #29275.
Could rebase, and update the PR description? Ideally this is now just blocked on our supported compiler versions.
Concept ACK - maybe upstream will take these patches as well? I guess we can try and send them, given we'll have to send CMake fixes in either case. Rebased...
> Overall I think I agree with Josie that adding this new CKey serialization method seems to make a confusing situation a little worse and doesn't seem to offer major...
> Might still be good to better document this code though. Yea. I don't think we are going to make the suggested change in either case.
Note that this ultimately results in compile failure, but because we try and compile the `sha256_x86_shani.cpp` code, but fail because it `"needs isa option -msse4.1"`: ```bash In file included from...