fanquake
fanquake
> FWIW, the https://github.com/bitcoin/bitcoin/pull/29185 makes this PR outdated. Closing this for now, given it looks like we are going ahead with #29185.
Closing for now, given you've closed the remaining base PR (#24774). Let me know if this is incorrect / should be reopened.
> Addressed @fanquake's https://github.com/bitcoin/bitcoin/pull/27710#discussion_r1210341923. I don't see how this is addressed, looks like it's now just producing include suggestions that are incorrect/we don't want for the test code.
Concept ACK. We can also check the benchmarks in https://corecheck.dev/bitcoin/bitcoin/pulls/29057 when they become available. > I can either add a commit on top of this PR to do the switch...
> Behaves better if abnormal issues occur Can you elaborate at all? I assume this is something that occured in production? cc @instagibbs. Might be interested in reviewing?
> Tested https://github.com/bitcoin/bitcoin/commit/076aa5ee3e9d86cc5f0b4fdfe8926a7f6a7078a2 on Ubuntu 22.04: I'm not sure what's causing that (maybe a not-completely-clean build dir, and mix of compiled objects), but I don't have any issues with this...
Rebased for #25542. All binaries for our Linux HOSTS now build.
Rebased on top of #25633. Please review that first.
I've rebased on master for #25697 and added a couple commits that are not ideal, but make Windows Guix builds "work" for bitcoin-qt.exe. See the 8ddce8af136bf0c9908c7d8f690433de7d0df418 commit for details. It...
Rebased on master / updated #25633. This now produces binaries for all HOSTS.