fanquake

> but should be rebased on a recent base commit to ensure all new tests/checks run successfully. Agree. This branch is currently based off (8a9ffec0a257da659ba54c5073bfc820986ae9c1). > Should https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki#getblocktemplate-changes be updated...

Concept ACK > That's not a reason to rebase. That's a flaw in QA infra. There's a myriad of reasons to keep development branches rebased up and/or up to date....

Added to the 24.0 milestone.

@luke-jr do you want to rebase this, otherwise I can drop it back off the milestone.

cc @achow101 @darosior

Another post-merge comment here: https://github.com/bitcoin/bitcoin/commit/2b781ad66e34000037f589c71366c203255ed058#r83655059. > I think you want SIGNATURE_TYPE=7 in here, without it you're going to get a DSA-SHA1 destination back, at least from Java I2P. See the...

I've pushed all the remaining dates here back one week. To allow some extra time for merging additional changes.

I've now marked feature freeze as completed.

Given that this change is a copy of the changes from #21284, you should cherry-pick and use the commit from that PR. Rather than copy the changes into your own...

#24090 was closed with no comment. @Crypt-iQ do you want to follow up here?