Robin Scheibler comments

Results 96 comments of


Robin Scheibler

Assertion Error: pyroomacoustics.build_rir.fast_rir_builder

Thank you very much for providing the extra information. This seems to be an error with the cython code that builds the RIR from the information about the echo delays...

Assertion Error: pyroomacoustics.build_rir.fast_rir_builder

Sorry for coming back so late to this issue. Indeed, the code in soundsource is something left-over from the previous implementation of the Room class. In recent version of pyroomacoustics,...

Extract a formula or a filter to generate the reverb effect of an audio in a room for a realtime application

Hi @abu100 , if you want to have dynamic moving sources in real time, the performance might not be good enough. If you only want to have a number of...

Inconsistent ```ValueError: The source must be added inside the room``` raised

Thanks for reporting! Have you made sure the normals of the walls are all pointing outward from the room ? I think this is important for the check to work...

Inconsistent ```ValueError: The source must be added inside the room``` raised

Is there a definition of the mesh being *manifold* ? I am not familiar with the term. My guess would be that the code is not super friendly to weird...

Inconsistent ```ValueError: The source must be added inside the room``` raised

Thanks! Indeed `numpy-stl` it was, I even wrote that example myself 😅 Would you also share the fixed version of the mesh for me to try ?

Inconsistent ```ValueError: The source must be added inside the room``` raised

Now I am not sure anymore. Which file did you share in the repo ? The one before or after pymeshfix ? I tried a little bit more and it...

When I try room.compute_rir() again，is it intended that the ISM or Ray-Tracing will not be re-modeled?

Hi @AlanLiudx , yes this is more a feature than a bug. There is a lot of states in the internals, and because you can call intermediate functions (such as...

When I try room.compute_rir() again，is it intended that the ISM or Ray-Tracing will not be re-modeled?

You are totally correct, this is far from an ideal situation... 😰

When I try room.compute_rir() again，is it intended that the ISM or Ray-Tracing will not be re-modeled?

Thanks for sharing! I think the values of `ism_needed` and `rt_needed` depend on the options provided when constructing the object. Another solution would be to not have intermediate methods (like...