Fahrzin Hemmati

Results 49 comments of Fahrzin Hemmati

Sorry, needed to get something else done for work, but coming back to this now.

Thank you @rickeylev! I assume this will be merged by copybara or something in the coming weeks? Do I need to do anything to get it into the next 6.x...

I took @damienmg's suggestions and added a `stub_template` attribute and a test. Hopefully that solves your (and my) problem!

My current use case is that I'd like to insert code that runs in the stub for a certain subset of rules, such as enabling (and extracting) coverage instrumentation for...

Any update here @brandjon? I can update my PR again if we're okay allowing custom stubs on the `py_binary` rules itself. Otherwise, we will have to continue using a fork...

FYI, I've put out a new PR with changes to the runtime (that I think is close to getting in, but @rickeylev decides that): https://github.com/bazelbuild/bazel/pull/16806 Once that's in, a new...

Not other than making the changes necessary :D I'm coming back to this now so I hope it's ready this week

Yes, there should be a separation. Unit tests should be plenty, but fast, since they test the logic in question, while integration tests should be fewer but mock as little...