bazel Enable custom py_binary stub_template attribute (via py

Fixes #137, but unlike my approach in #6632, this adds an attribute to py_runtime rather than to py_binary

Open to suggestions on the attribute name and documentation

Nov 19 '22 22:11 fahhem

Thanks Richard! I replied to the questions, and I'll follow up on the actionable comments today

Nov 22 '22 19:11 fahhem

Done with the review, thank you @rickeylev !

Nov 23 '22 19:11 fahhem

Seems like the main change needed was just to switch to ctx.file and then fix the two places I had workarounds to "support" ctx.attr being not a FileApi? I've done the above and it looks like the tests are passing, are we good to merge?

Nov 30 '22 22:11 fahhem

@fahhem just bumping this in case it got lost

Dec 14 '22 23:12 rickeylev

Sorry, needed to get something else done for work, but coming back to this now.

Dec 21 '22 20:12 fahhem

LGTM.

Dec 21 '22 23:12 rickeylev

Thank you @rickeylev! I assume this will be merged by copybara or something in the coming weeks? Do I need to do anything to get it into the next 6.x release?

Jan 06 '23 04:01 fahhem

Heyas,

Just got back from vacation the other day. The Bazel-pr-importer-team (that's who the "awaiting-pr-merge" label notifies) starting importing it, but some failures popped up so I had to fix those first. I'm now re-importing it and it's looking good; I expect to submit it tomorrow or Monday, and it'll show up on github automatically shortly thereafter.

Jan 06 '23 04:01 rickeylev

Enable custom py_binary stub_template attribute (via py_runtime)