fahadnayyar

Results 12 comments of fahadnayyar

[cxx-interop] Import default ctor of C++ foreign ref types as Swift Initializer

Some pointers from an offline discussion with @j-hui : - We need to think more about access specifiers of the synthesized factory based on access specifier of operator `new` and...

[cxx-interop] Import default ctor of C++ foreign ref types as Swift Initializer

@swift-ci please smoke test

[cxx-interop] Import default ctor of C++ foreign ref types as Swift Initializer

@swift-ci please smoke test macos

[cxx-interop] Import default ctor of C++ foreign ref types as Swift Initializer

@swift-ci please smoke test

[cxx-interop] Import default ctor of C++ foreign ref types as Swift Initializer

@swift-ci please test macOS

[cxx-interop] Import default ctor of C++ foreign ref types as Swift Initializer

Enabling auto-merge on this patch with these points in mind: - Currently the feature is hidden under `-enable-experimental-feature CXXForeignReferenceTypeInitializers`. I have added sufficient tests to demonstrate that the feature is...

[cxx-interop] [nfc] Rename CXXForeignReferenceTypeInitializers to SuppressCXXForeignReferenceTypeInitializers

@swift-ci please smoke test

[cxx-interop] [nfc] Rename CXXForeignReferenceTypeInitializers to SuppressCXXForeignReferenceTypeInitializers

@swift-ci please test

[cxx-interop] convert CXXForeignReferenceTypeInitializers into SuppressCXXForeignReferenceTypeInitializers to be an opt-out flag

@swift-ci please smoke test

[cxx-interop] convert CXXForeignReferenceTypeInitializers into SuppressCXXForeignReferenceTypeInitializers to be an opt-out flag

NOTE: I am addressing rdar://145098078 as well in this patch. `SWIFT_RETURNS_(UN)RETAINED` related diagnostics (specially the warning in case of unannotated C++ APIs returning `SWIFT_SHARED_REFERENCE` types) were not triggering for cases...