fadi-botros

When you generate files using Swift generator, you find both `NSCoding` and `toDictionary`/`fromDictionary` I think it could be more readable and small if the `NSCoding` comformance was just delegating to...

Update the Package format to the SPM 4 format, made the library .dynamic

1

Please don't put it on the master branch (for master, please use ` .library(name: "PerfectLib", targets: ["PerfectLib"]) ` instead of ` .library(name: "PerfectLib", type: .`dynamic`, targets: ["PerfectLib"]) ` Until Apple...

Please, this is not to be pushed on "master", but another branch to be used when Apple fixes the dynamic library bug. (Temporarily one can use this try [https://github.com/fadi-botros/swift-package-manager](url) )

What if a detail inside the ViewModel changed ??

1

https://github.com/NohaSamir/PopularMovies/blob/44d3969858e10013bd3c359c48aab475913b2501/app/src/main/java/com/example/android/popularmovies/view_model/MainViewModel.java#L25 More good work by you. But, what if a `Movie` (for example, if there is a number of reviews), changed ?? Would you reload all data by changing the...