Lukasz Czaplicki

Results 8 comments of Lukasz Czaplicki

I think `attachToRoot` parameter should be `false` by default. As @antoniolg mentioned that would be mainly used in Adapters where we want `false`. Being forced to always add that extra...

I'll just post method signature here. Later today or tomorrow prepare PR to be more precise and kick off detailed discussion. ```kotlin @Suppress("UNCHECKED_CAST") inline fun AdapterView.onItemClick( crossinline onItemClick: (item: ITEM)...

Work in progres PR is ready https://github.com/android/android-ktx/pull/484. I need to finish some tests but most importantly I'm waiting for feedback on implementation.

@sohailehmad please note that with default argument for onNothingSelected you still can use method without specifying both arguments and can invoke it like that: ``` adapterView.onItemSelected { /* action */...

PR updated and ready for review.

Work in progress as I need to at least add tests for `onItemSelected`.

PR was started off from discussion here: https://github.com/android/android-ktx/issues/470

Ready to review. CI is filing because of `GCLOUD_SERVICE_KEY env variable is empty.` but I don't think I can do anything about that myself and seen that across different PRs...