Frederic M

Results 44 comments of Frederic M

Hi @mloiseleur, Sure, at the moment I'm mostly interested by the Cloudflare proxied annotation. I did my best adding some tests (also trying to stick with standards seen in other...

Good morning, Is this OK to test or do I need to provide some more information? Thx

Hi @mloiseleur did you have any chance to look at this one? Is it OK to test? Thx

@mloiseleur do you have any idea of what could be wrong here? ``` --- FAIL: TestAmbassadorHostSource (0.00s) --- FAIL: TestAmbassadorHostSource/Service_with_load_balancer_hostname (0.71s) ambassador_host_test.go:322: Targets expected "8.8.4.4;8.8.8.8", got "dns.google" ambassador_host_test.go:322: RecordType expected...

Hello, can anybody help with the failing test (see comment above)? Thx

@mloiseleur I tried rebasing but it would ask me to fix conflicts that have nothing to do with my code.. so instead I merged master into my branch and here...

> To remove your last merge commit, something like: > > ```shell > git reset --hard HEAD~1 > git push > ``` > > Should do it. Yeah, had to...

Hey there 👋 anything else I can do to push this forward? Thanks!

Hi, any chance this gets a review? Thx