feat(ambassador): add support for provider specific annotations

[fad3t]

Description This change adds support for provider-specific annotations for the ambassador source.

[k8s-ci-robot]

Hi @fad3t. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mloiseleur]

@fad3t Would you please : 0. Detail and document the provider specific annotations you would want to use

1. Add test case with annotations on this source

[fad3t]

Hi @mloiseleur,

Sure, at the moment I'm mostly interested by the Cloudflare proxied annotation. I did my best adding some tests (also trying to stick with standards seen in other sources), please don't hesitate to share comments or ideas to improve it further.

Thx, Fred

[fad3t]

Good morning, Is this OK to test or do I need to provide some more information? Thx

[fad3t]

Hi @mloiseleur did you have any chance to look at this one? Is it OK to test? Thx

[mloiseleur]

/ok-to-test

[mloiseleur]

@fad3t Sure. It still needs some documentation on this feature.

[fad3t]

@mloiseleur do you have any idea of what could be wrong here?

 --- FAIL: TestAmbassadorHostSource (0.00s)
    --- FAIL: TestAmbassadorHostSource/Service_with_load_balancer_hostname (0.71s)
        ambassador_host_test.go:322: Targets expected "8.8.4.4;8.8.8.8", got "dns.google"
        ambassador_host_test.go:322: RecordType expected "A", got "CNAME" 

Those tests run OK locally, and the resolveLoadBalancerHostname flag is set to true when calling extractLoadBalancerTargets, so the hostname should have been replaced by the corresponding IPs.

As for the docs, did you have something in mind? I see there's already some docs about annotations, I've simply flagged the fact Ambassador now supports provider-specific annotations.

Thanks

[fad3t]

Hello, can anybody help with the failing test (see comment above)? Thx

[mloiseleur]

The test has been fixed. @fad3t : You just need to rebase.

[fad3t]

@mloiseleur I tried rebasing but it would ask me to fix conflicts that have nothing to do with my code.. so instead I merged master into my branch and here it is. Yet it looks like it has plenty of changes unrelated to my feature :) Any recommendation to make this clean?

[mloiseleur]

To remove your last merge commit, something like:

git reset --hard HEAD~1
git push

Should do it.

[fad3t]

To remove your last merge commit, something like:

git reset --hard HEAD~1
git push

Should do it.

Yeah, had to look at the commit SHA as I didn't squash during the merge. Anyway now it looks OK and checks are green :) let me know if that's good for you - and thx for the help!

[mloiseleur]

That's far better now. /lgtm

[fad3t]

Hey there 👋 anything else I can do to push this forward? Thanks!

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [szuecs]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[fad3t]

Thanks a lot 👍