ros2_introspection icon indicating copy to clipboard operation
ros2_introspection copied to clipboard

fix: adapt to rosbag2 foxy changes

Open rokel opened this issue 5 years ago • 4 comments

Thanks for making this repository available! Had to make some minor tweaks to get it building with foxy.

Namely:

  • Required rosbag package is now rosbag2_cpp
  • get_typesupport has been split into get_typesupport_library and get_typesupport_handle

Something that tripped me up - the client library needs to persist a shared pointer to the library for the lifetime of any typesupport handles.

rokel avatar Jun 12 '20 09:06 rokel

thanks a lot. But wonçt this change brake the compilation in Eloquent?

Rosbag2 is a moving target, and I have the feeling that the definitive solution is to copy and paste the code I need from there inside my library.

facontidavide avatar Jun 12 '20 11:06 facontidavide

Fair point, I suppose the alternative would be maintaining separate branches for each release, but would be a lot of work. Feel free to close this PR, hopefully will still be useful to others :)

rokel avatar Jun 12 '20 12:06 rokel

this PR is very useful to me to see the changes I will be supposed to do, if I move to Foxy.

Therefore i will not close it yet.

Thanks a lot

facontidavide avatar Jun 12 '20 12:06 facontidavide

This is awesome, thank you so much @rokel

nyxaria avatar Aug 20 '20 11:08 nyxaria