fix: adapt to rosbag2 foxy changes
Thanks for making this repository available! Had to make some minor tweaks to get it building with foxy.
Namely:
- Required
rosbagpackage is nowrosbag2_cpp -
get_typesupporthas been split intoget_typesupport_libraryandget_typesupport_handle
Something that tripped me up - the client library needs to persist a shared pointer to the library for the lifetime of any typesupport handles.
thanks a lot. But wonçt this change brake the compilation in Eloquent?
Rosbag2 is a moving target, and I have the feeling that the definitive solution is to copy and paste the code I need from there inside my library.
Fair point, I suppose the alternative would be maintaining separate branches for each release, but would be a lot of work. Feel free to close this PR, hopefully will still be useful to others :)
this PR is very useful to me to see the changes I will be supposed to do, if I move to Foxy.
Therefore i will not close it yet.
Thanks a lot
This is awesome, thank you so much @rokel