PlotJuggler icon indicating copy to clipboard operation
PlotJuggler copied to clipboard

Published 20 hours ago • verified publisher icon facontidavide

[WIP] - ZeroMQ Topics Support.

Open bonkuraps opened this issue 2 years ago • 7 comments

Work In Progress. I'm going to have some questions later on, that's why I've decided to submit it while it's still in WIP. 😃

bonkuraps avatar Aug 21 '22 08:08 bonkuraps

@facontidavide, few questions for you:

  1. https://github.com/facontidavide/PlotJuggler/pull/730/files#diff-9f7a849999e617d339dbef75cc5c68fd6e230040cf1d0a6ba398898901344d19R195 <- I'm open for discussion about this one.

  2. What separators should we use for filters? (right now while testing I've assume the most basic scenario aka empty whitespace ref: https://github.com/facontidavide/PlotJuggler/pull/730/files#diff-9f7a849999e617d339dbef75cc5c68fd6e230040cf1d0a6ba398898901344d19R206)

Any other ideas?

bonkuraps avatar Aug 21 '22 10:08 bonkuraps

This pull request introduces 1 alert when merging b830e75bbc8e67bb55dd2ea5d2e74531dab0fda3 into c559f915a726d759f4ba23e7153173ed7b34c90e - view on LGTM.com

new alerts:

  • 1 for Constant return type on member

lgtm-com[bot] avatar Aug 21 '22 11:08 lgtm-com[bot]

Thanks for contributing. I will be away from the computer for the next 2 weeks. I will review this PR afterward.

I probably prefer ";" as separator

facontidavide avatar Aug 22 '22 10:08 facontidavide

Thanks for contributing. I will be away from the computer for the next 2 weeks. I will review this PR afterward.

I probably prefer ";" as separator

Sure, sounds good!

Have a nice vacation then I guess? :)

bonkuraps avatar Aug 22 '22 10:08 bonkuraps

@facontidavide Hope you had great vacations, any input on this one? :)

bonkuraps avatar Sep 06 '22 12:09 bonkuraps

Would you please provide a longer description of what this PR does, including screenshots? I am collapsed with work and that would save me some time :sweat_smile:

facontidavide avatar Sep 06 '22 12:09 facontidavide

@facontidavide I've updated the description and PR is ready for review. I also recorded the functionality in action but the file got so big that I needed to upload it to Google Drive 😕

bonkuraps avatar Sep 25 '22 13:09 bonkuraps

explore the regex with: https://regex101.com/r/Ktgw7j/1

bonkuraps avatar Sep 25 '22 13:09 bonkuraps

@facontidavide any thoughts on this one? :)

bonkuraps avatar Oct 14 '22 16:10 bonkuraps

I used the 3.6.0 installation on windows and did not find an option for zeromq to filter themes. image

nealwang123 avatar Mar 03 '23 03:03 nealwang123

I used the 3.6.0 installation on windows and did not find an option for zeromq to filter themes. image

Sorry, I just found out that the filter topic feature is added in version 3.6.1. I am compiling it with vcpkg.

nealwang123 avatar Mar 03 '23 07:03 nealwang123