PlotJuggler icon indicating copy to clipboard operation
PlotJuggler copied to clipboard

[WIP] Merge data instead of replacing it

Open TonyWelte opened this issue 3 years ago • 2 comments

This changes the way new data is added. New data with an already known name is merged with the old data (if the user wants to keep it).

This enables multiple bags recorded over the same timespan to be replayed (as "plotjuggler::rosbag1::consecutive_messages" can be merged).

It also enables to load simultaneously data recorded over a different timespan.

Relates to PlotJuggler/plotjuggler-ros-plugins#27

TonyWelte avatar Jul 28 '21 14:07 TonyWelte

Thanks for taking the time to contribute to plotjuggler, but I am afraid that it may introduce some unexpected behavior.

I would feel more comfortable if a third option "Merge data" is available in

      QMessageBox::question(this, tr("Warning"), tr("Do you want to remove the previously loaded data?\n"),

facontidavide avatar Aug 15 '21 16:08 facontidavide

I agree adding a third option is best. Now the "Yes" button is the same as before, the "No (remove duplicates)" should be the same as the old "No" button, only the "No (merge duplicates)" adds a new behavior.

TonyWelte avatar Aug 16 '21 16:08 TonyWelte

@facontidavide would there still be a need for this feature? What do you think?

bonkuraps avatar Aug 18 '22 16:08 bonkuraps

There are a number of potential drawbacks that I need to analyze. In general, there is a 80% probability that this is not a good fit for PJ, at this moment of time.

This doesn't mean I don't appreciate your contribution, but i must be mindful about the feature I merge.

facontidavide avatar Aug 18 '22 16:08 facontidavide

Ok, that's fine! Do you see any other tickets that might be worth going through?

bonkuraps avatar Aug 18 '22 16:08 bonkuraps

Thanks a lot for the help offer!!! Maybe #724 , #705, #681

facontidavide avatar Aug 18 '22 23:08 facontidavide