Michael Robinson comments

Results 90 comments of


                                            Michael Robinson

Random increment math

This looks interesting, if anyone wants to have a go, it'd be great to see what it might look like.

Loading bar appears in centre of screen on ipad when keyboard is open

Could you please provide a JSFiddle or Plunkr that replicates the issue?

Can't make the bar reach the end while extending the scope with a big amount of data

Confirmed. Interestingly it seems OK if I change the code to do the scope assignment in a timeout: http://codepen.io/faceleg/pen/eZgdGq

Define an AMD module if require.js is loaded

LGTM but needs tests and the change I suggested. Thoughts @chieffancypants?

add statusChanged event for status synchronization with 3th parties

How frequently does this event get called? My only concern is that this could cause performance issues. If this is the case, then it should be off by default and...

add statusChanged event for status synchronization with 3th parties

Agree that listening on `$rootScope` is fine for this (therefore `$emit`) I'll take @chieffancypants' silence on the config flag and off by default to mean he agrees. And tests :)

Loading bar keeps loading if an HTTP request is blocked due to a CSP policy

Could you please provide an example?

iw selects spaces and newlines

Agree, this behaviour was surprising for me

iw selects spaces and newlines

`iw` also eats `,` characters.

iw selects spaces and newlines

@angelic-sedition does #21 result in more expected behaviour?