Fabian Yamaguchi

Great catch! It's a pity that there's no `scala.collection.immutable.Deque` - simply exchanging the collection would be ideal because bringing in a global data structure makes this algorithm more complex. I'm...

Doesn't guava have a deque that we can use?

Unless there's a readily available container we can use from a standard library or semi-standard library such as guava, I'd like to table this for now. The gains in performance...

The tests are still red, btw, so, I think measurements only make sense once they're green.

Can we close this one?

The major rewrite is merged. Please test again.

I think this is just an effect that is produced by the dot-plotting code, which aims to simplify the representation. In the underlying graph, we in fact create REACHING_DEF edges...

Yep, I can reproduce this. Let me take a look.

I've tracked it down to an overtainting for method parameters in DDG calculation but I'll need some more time tomorrow for this one.

https://github.com/joernio/joern/pull/1031