Fabricio Cabral comments

Results 78 comments of


                                            Fabricio Cabral

org.cactoos.text.Replaced uses StringBuffer instead of StringBuilder

@victornoel Yeah, good idea! But we need take care beacuse some classes use `StringBuffer` intentionally, as `InputOfTest` and `TextOfTest`.

IterableOf, MapEntry and MapEnvelope should use HashCode instead of own hash code algorithm

@victornoel is it better now?

IterableOf, MapEntry and MapEnvelope should use HashCode instead of own hash code algorithm

@victornoel welcome!

Some object's attributes without final modifier

@victornoel Yep. Making attributes final forces immutability which has as (good) side-effect thread-safety (I think so).

Some object's attributes without final modifier

@victornoel We can use these `Atomic*` and add in the documentation that classes are not thread-safe and left puzzles to add tests using these classes with threads. WDYT? BTW, you're...

Some object's attributes without final modifier

@andreoss 1. I won't problems with locks if just use a "simple" `Queue`? Is it work fine? 2. Ok! Thanks!

Need to improve documentation about how uses TeeInput/TeeOutput classes

@victornoel when I've been written this issue, I was thinking in copy the `Output` content to an `Input` to be allowed read for other object. I don't know if is...

Need to improve documentation about how uses TeeInput/TeeOutput classes

@victornoel it seems ok. Do you prefer I closed this issue now?

Need to improve documentation about how uses TeeInput/TeeOutput classes

@victornoel Definitely we need improve this documentation! :)

Need to improve documentation about how uses TeeInput/TeeOutput classes

@0crat status