Fábio Henriques

Results 37 comments of Fábio Henriques

Putting this on HOLD because I'm going to be OOO next week, and will return on May 6th.

@unimonkiez Thanks for your review! About the migration, even if I implement it won't be 100% seamless as it would require changes in the application as well, specifically how the...

@unimonkiez I updated the PR with the following changes: - Addressed the requested changes - Implemented a migration for the new Android font linking logic. Tested with edge cases as...

Hi @unimonkiez , did you have a chance to take a look at the latest changes on this PR? Thanks!

Hi @unimonkiez, just bringing this PR to your attention again, I appreciate any feedback or action you could take. Thanks!

Hey @cortinico, can you assign me to this one [react/animated/NativeAnimatedInterpolationTest.java](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/animated/NativeAnimatedInterpolationTest.java)?

Hi @cortinico , can I also get the last one [react/bridge/FallbackJSBundleLoaderTest.java](https://github.com/facebook/react-native/tree/main/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/FallbackJSBundleLoaderTest.java)? Will start working on the 2 files in a few minutes.

Hi @sakluger , I don't work at Meta, I just reviewed because I'm from the same company of the PR author.

@fcaldarelli Just complementing @DominicTobias info.. The "required" option was introduced in Gradle 6.8: 6.7.1 -> https://docs.gradle.org/6.7.1/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled 6.8 -> https://docs.gradle.org/6.8/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled 6.8 source code -> https://github.com/gradle/gradle/blob/v6.8.0/subprojects/reporting/src/main/java/org/gradle/api/reporting/Report.java And RN started using Gradle 6.8+...

You can use [patch-package](https://github.com/ds300/patch-package) as a temporary workaround while this PR is not merged yet, we are using in Expensify project -> https://github.com/Expensify/App/blob/main/patches/@onfido+react-native-sdk+7.4.0.patch