Fabian Pedregosa
Fabian Pedregosa
I'm unsure. Let me talk today with the other optax devs to see what they think On Sun, Feb 4, 2024, 19:50 Mohammed Hamdy ***@***.***> wrote: > ouch indeed! 😅...
@mmhamdy : I talked today with the pygrain devs, we're going to try to make it work on Python 3.9 . Give me a couple of days to try to...
BTW I submitted a PR fixing python 3.9 errors: https://github.com/google/grain/pull/338
yeah, one thing that worries me a bit more about pygrain is that it it doesn't seem to build on OSX (tried and failed), and probably also Windows (haven't tried...
thanks for updating @mmhamdy ! Very glad to see that the test now pass!
@mmhamdy : now that grain has builds for 3.9 (https://pypi.org/project/grain-nightly/0.0.6/#files), can you update with master to see if the tests pass?
@amosyou thanks for working on this! I see this is in draft mode, let me know when you'd like one of us to talk a look into it!
@amosyou : feel free to open a new PR if you want to take over this!
Thanks for looking into it @amosyou . Eliminating the "Alias for field ___" would already be better, even if we loose the type information IMO. Could you post a screenshot...
I think that looks good! (module some formatting issues that I thin are orthogonal to this issue). Could you submit a pull request for this? You're on 🔥 @amosyou !