optax
optax copied to clipboard
google-deepmind
Remove TF dependency in reduce_on_plateau example
This PR removes Tensorflow as a dependency in reduce_on_plateau.ipynb, and uses only TFDS, with grain for loading and preparing the dataset.
Addressing issue #656
ouch! yeah, I'm seeing from https://github.com/google/grain/blob/main/pyproject.toml that they require Python 3.10 ....
ouch indeed! 😅 What do you think? should we stick to notebook downloads until we get rid of either TensorFlow or Python 3.9?
I'm unsure. Let me talk today with the other optax devs to see what they think
On Sun, Feb 4, 2024, 19:50 Mohammed Hamdy @.***> wrote:
ouch indeed! 😅 What do you think? should we stick to notebook downloads until we get rid of either TensorFlow or Python 3.9?
— Reply to this email directly, view it on GitHub https://github.com/google-deepmind/optax/pull/768#issuecomment-1925895311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDZBYXEP4G7ZGONXUNHQDYR7Q6XAVCNFSM6AAAAABCYTNHXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVHA4TKMZRGE . You are receiving this because you were mentioned.Message ID: @.***>
@mmhamdy : I talked today with the pygrain devs, we're going to try to make it work on Python 3.9 . Give me a couple of days to try to get this working 😉
Sounds great! Also, the MNIST issue has been solved, so I'll be working on the other examples in the meantime.
BTW I submitted a PR fixing python 3.9 errors: https://github.com/google/grain/pull/338
yeah, one thing that worries me a bit more about pygrain is that it it doesn't seem to build on OSX (tried and failed), and probably also Windows (haven't tried there). Before committing replacing TF with pygrain it would be important to make sure that those platforms are supported (just to say that it might take a bit before we merge these PRs unfortunately)
Well, replacing TensorFlow wasn't expected to be a walk in the park anyway 😃. But we've come a long way and I see that the people at pygrain are working daily on it.