Fabi

Results 8 comments of Fabi

I don't think #10961 fully fixed the issue. Here `powerfeed` is set using the removed `connected_endpoint`: https://github.com/netbox-community/netbox/pull/10961/files#diff-244731798e872e98b04c335c35679f920c3e5c90e8bf2340471f7910bd0449cdL232 Which means it will always be `None`. I think the proper fix would...

I'm fairly busy with other things right now, not sure when I can get around adding this feature. But I'll be more than happy to review a PR if anybody...

> so basically add a comment field to ObjectChange. yep, thats the model change that is required. and then when making changes in netbox there would need to be a...

For the API I would suggest using a header to keep things out-of-band and backwards compatible. For UI edits this could be achieved with a field on the confirmation pop-up....

Would you be open to making it an API only feature? I don't have enough experience with UI/UX deisgn to make a sensible suggestion here :-/

Found a few more: https://github.com/netbox-community/netbox/blob/c8aac13ceebf851368f6c7c2fbc6a783fc2e7bda/netbox/dcim/api/serializers_/base.py#L16-L17 and https://github.com/netbox-community/netbox/blob/c8aac13ceebf851368f6c7c2fbc6a783fc2e7bda/netbox/dcim/api/serializers_/cables.py#L94 Thanks for looking at this :)

I've put up #16627 a while ago in case you missed it. Thanks!