Krzysztof Krztoń

Results 89 comments of Krzysztof Krztoń

@Mgsy Could you take a look and test if everything works fine?

There is a general problem with compatibility of nested list items between Word and content we can generate in the editor. In Word you could easily create a list items...

@Tade0 see my comment in the PR https://github.com/cksource/ckeditor-plugin-a11ychecker/pull/218#issuecomment-237171164.

@Tade0 There are still unanswered comments from @mlewand, I also added one myself, please take a look there - https://github.com/cksource/ckeditor-plugin-a11ychecker/pull/206.

It looks like a redundant code indeed. But I am not sure if there wasn't a reason for that. I would check to be sure if hiding the balloon panel...

@Tade0 I added a [comment](https://github.com/cksource/ckeditor-plugin-a11ychecker/pull/215#issuecomment-235232971) to your PR ticket.

Overall the code looks good but it seems to me that there are a few things to polish: 1. The [test which checks script loading](https://github.com/cksource/ckeditor-plugin-a11ychecker/blob/b608bf54d8bb34e31dd6bdebb8df3a156d1f1335/tests/quailinclude.js) was added but there is...

I found that one test is failing (https://github.com/cksource/ckeditor-plugin-a11ychecker/blob/t/200a/tests/Controller/CheckingMode.js#L46) throwing `Unexpected error: viewerPanel.blur is not a function`. I run tests with dev version using [`t/200a`](https://github.com/cksource/ckeditor-plugin-a11ychecker/tree/t/200a) branch with CKEditor [`major`](https://github.com/ckeditor/ckeditor-dev/tree/major) branch. Is...

> I think we need to move forward with all of them anyway and just comment those bits out for now. That's what I did in the feature-rich initially. >...

I'm putting this on review and rest of demos (with external plugins), I'll cover in separate branch as mentioned: > Or I can prepare separate branch migrating all demos with...