Krzysztof Krztoń

Results 89 comments of Krzysztof Krztoń

Agree with @Dumluregn that it is breaking change. So far we haven't had any cases where one would like to use both (CKE4 and CKE5) components at the same time...

Hi @Nunivenkatarao, I see it works as you described in our [From sample](https://ckeditor.com/docs/ckeditor4/latest/examples/angular.html#/forms) but we have to check if it is an issue with the sample code or component itself...

If we would like to have consistent behavior with CKEditor 4, then while in the source mode entire/up-to-date HTML should be returned (with all modifications done in source mode included....

> It seems to work correctly, source mode returns updated HTML. The issue with the submit button is just a minor issue of the sample. @jacekbogdanski are you sure about...

> I didn't really investigate the issue with the submit button, I just don't see how it's related to the linked issues with sourcemode encoding. That's fine, it is related...

The workaround could be disabling some TS checks with: ```javascript "compilerOptions": { "skipLibCheck": true } ``` in `tsconfig.json` file (helped in the docs case - see ckeditor/ckeditor4-docs@4ecd6f3).

This is CKEditor 4 issue related to a fact that [`change` event](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_editor.html#event-change) is not triggered by applying native grammar correction - https://github.com/ckeditor/ckeditor-dev/issues/2384.

The quick workaround for this issue would be to manually trigger `change` event as suggested in https://github.com/ckeditor/ckeditor-dev/issues/2384: ```html ``` were `triggerChangeEvent` should be defined as follows: ```js triggerChangeEvent( evt )...

Here is the comment with more details on this issue - https://github.com/ckeditor/ckeditor5/issues/1830#issuecomment-505275726.