Francesco Montorsi

Hi @satyabratabharati , I raised some cosmetic comments at some points of the new files but I'm raising in this commetn the most important review points: * adding e.g. in...

About this: > * We need to find the best Prometheus-native way to expose different classes of KPIs: those related to the whole system (CMonitorSystem), those related to cgroups only...

To test the build system with Prometheus you can run: ``` cd t/cmonitor/collector make -f /cmonitor/.copr/Makefile rpm outdir=/tmp/cmonitor-rpm ``` THis is the way COPR will start the build of cmonitor-collector....

Hi I didn't go too much in the details of the review, but I raise first few major comments: 1) the changes to CMonitorCgroups::sample_processes() I think are producing an invalid...

Hi @satyabratabharati , sorry for the huge delay but finally I've done the PR review. I raised only minor review points. I think it's a great work so I'm happy...

Hi @satyabratabharati , I think this MR still needs some work. Major points to raise are: 1. log file: we need this utility to write a log file using Python...

Hi @lucabonamini , currently there is no way to specify a single PID or process name. However if you have your process run under a dedicated cgroup you can have...

fixed for the "docker-userapp" example

I tried and checked pidstat command but it does not seem to work: root@LMC:~# ps aux | grep nofork message+ 634 0.5 0.2 4748 2336 ? Ss Mar12 334:00 /usr/bin/dbus-daemon...

Right I see. Unfortunately I don't have much time to help on this... but if you can provide a patch to implement this behavior, it would be welcome! Regarding "unset"...