Thulio Ferraz Assis
Thulio Ferraz Assis
@aherrmann Interesting work here. Is there something I could do to help push it across the finish line?
That's amazing. Thanks for the quick reply.
The current test failure is due to files clashing inside the action. I'll patch an alternative.
Thanks for the reviews, @alexeagle, @rickeylev and @chrislovecnm. I believe I addressed most of the comments. I only pushed back the ones I really thought didn't make sense.
Thanks for this. How about we split this into 3 PRs? The first would be the changes to pre-commit, the second using click, and the third adding the new functionality.
I believe my last fix on https://github.com/bazelbuild/rules_python/pull/1053 will cover your use case with what @aignas described. I merged it yesterday. I'm still open to reviewing your PR, though.
I think the best way forward is to support the `gazelle:default_visibility` directive. I don't have the bandwidth to do this right now. @aignas, do you? Otherwise, @aryamccarthy, Go is really...
This code was added 6 years ago: https://github.com/bazelbuild/bazel-gazelle/commit/cdc77d08956c8f4b9a0509878cda3b9ce9e02095. This is when only the Go generation existed. This is not a rule. If it were, it would be enforced by the...
I appreciate the time you've put into this discussion and raising a point that makes your adoption of the Python extension for Gazelle difficult. As an open-source project, we have...
It also occurred to me that you could probably just use https://github.com/aspect-build/plugin-fix-visibility to fix your visibility issues.