Thulio Ferraz Assis comments

Results 72 comments of


                                            Thulio Ferraz Assis

Linking `rules_python` libpython with PyO3

The `.so` file is a symlink to the real versioned shared object. ``` lrwxrwxrwx 1 1000 1000 19 Aug 18 14:51 libpython3.9.so -> libpython3.9.so.1.0 -rwxrwxr-x 1 1000 1000 37M Jan...

Standardise on pip_parse

The breaking change is acceptable. Gazelle can produce the right label for users who rely on it. I have not reviewed the code yet, thought. Will do next.

Handle python/Python dir/file in toolchain archive

Sorry, I missed this PR. It ended up getting fixed here https://github.com/bazelbuild/rules_python/commit/2cdad9e18eda451e486737ff3cddc25ddd579c8e as I extracted the fix from the bigger change I was doing in https://github.com/bazelbuild/rules_python/commit/26526a501f5ee67b370744a76a3aa3cf98d212f4.

Replace cc_import with cc_library for libpython

I still think the approach in the PR is correct. In practical terms, the difference between cc_library and cc_import is that cc_import only takes 1 file, so in the case...

ignore .pyc files in py_library() targets created in pip_install_dependencies()

This is related to https://github.com/bazelbuild/rules_python/pull/749. Please, see the related PRs in that description.

ignore .pyc files in py_library() targets created in pip_install_dependencies()

Please, reopen if running as non-root doesn't solve your problem.

ignore .pyc files in py_library() targets created in pip_install_dependencies()

I reopened. You can just update this PR so we keep the history.

ignore .pyc files in py_library() targets created in pip_install_dependencies()

I don't think making these `.pyc` files read-only makes sense as it does with the hermetic toolchain. Probably ignoring them from the glob is better in this case. @mattem what...

Wrap reqs defined by `pip_parse.install_deps` in `maybe`

@mattem What do you think about this?

feat: add py_pytest_main entrypoint

Following the decision that rules_python will not be test-framework-specific, this effort landed in https://github.com/aspect-build/rules_py/commit/6b1fcb753ec643d2418d538eb9d1f8a0159f65b5.