f-luo

Results 4 comments of f-luo

> @f-luo could you try prefixing the chdir value with this in js_binary itself? https://github.com/aspect-build/rules_js/blob/main/js/private/js_binary.bzl > > That would then close #2275. I do think that would address it more...

Okay, that sounds good. I can take a stab at it. But as an FYI I will be traveling for the next 2 weeks, so will come back to this...

@jbedard , thanks for checking in. Just repro'ed it on the latest `2.8.1`. The repro steps and outcome is consistent with the report at https://github.com/aspect-build/rules_js/issues/2343. The fix in this PR...

Yup, np! Just added a simple e2e test. I wasn't sure if there's a hook somewhere to automate running e2e. I've testing via: ``` bash e2e/js_binary_workspace/test.sh ``` Let me know...