Fabrizio Ferrai
Fabrizio Ferrai
Is this a duplicate of #404?
I think we could merge this already, but I'd first like that we figure out a good testing story for this, because if we can't properly test that the changes...
Oh, it looks like we can call a process with `unshare -r -n` to prevent it from reaching the network (on linux at least. We can run the offline tests...
@JordanMartinez I see. The location of both Dhall and Spago folders is dependent on the value of the `XDG_CACHE_DIR` environment variable. We could try to set that do a temp...
Yeah this is due to the smarts of how we parse the Config for publishing - right now we just raise an error the first time we encounter it, but...
@hdgarrood the reason why error messages are so far away from Dhall ones is that our config is a bit of a special Dhall file (for historical reasons, and backwards...
Spago does not emit an error when bundling an app's main module that does not have a `main` function
Good catch! This is interesting because `spago bundle` just [shells out to `purs bundle`](https://github.com/spacchetti/spago/blob/e07ff025f6feb5820ed1182f84dc76cb71fb86de/app/Spago/Build.hs#L128), which is happy to generate that malformed js. Pulp however [implements this check](https://github.com/purescript-contrib/pulp/blob/e8f492be76670c3cc1bb4b418b260740fca4f5b7/src/Pulp/Build.purs#L190), and fails with...
Spago does not emit an error when bundling an app's main module that does not have a `main` function
Ping @hdgarrood: thoughts on adding this check to `purs`?
Spago does not emit an error when bundling an app's main module that does not have a `main` function
@hdgarrood thanks for the context! It makes sense, I'll look into using the externs files for the check 👍
Spago does not emit an error when bundling an app's main module that does not have a `main` function
Indeed, but if it's necessary to rely on them and other tools (e.g. spago) start doing that too then it could make sense to include them in the public API?...