Eliezer Graber

Results 146 comments of Eliezer Graber

The [Kotlin Multiplatform Gradle Plugin](https://github.com/JetBrains/kotlin/blob/8d79fab109f79fdb6272f73dcddbc472ac7a3af8/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/dsl/KotlinTargetContainerWithNativeShortcuts.kt#L29) has the following way of getting the common test source set: ``` private fun mostCommonSourceSets() = DefaultSourceSets( sourceSets.getByName(COMMON_MAIN_SOURCE_SET_NAME), sourceSets.getByName(COMMON_TEST_SOURCE_SET_NAME) ) ``` [where `COMMON_TEST_SOURCE_SET_NAME` is defined...

> I'm unsure about this. We might have users that are fine having rules enabled only on detektMain and not on detekt. Perhaps the warning should be configurable? Yes please...

@AlecStrong I took a stab at this by adding `other_expr` to `overrides` and adding ``` other_expr ::= {extension_expr} | window_function_invocation ``` to match the sqlite flow chart for `expr` but...

https://github.com/eygraber/sqldelight/tree/repro-2799

Ah I had tested with that earlier but I forgot to include it in this branch. In any case, it still fails with the same error.

@AlecStrong I took another look (and updated https://github.com/eygraber/sqldelight/tree/repro-2799 to make the failing test actually be correct sqlite) and the only thing I can think of is that something else is...

@JakeWharton I started taking that approach recently, and there is some friction to using it. For example, I would like the database and queries to be internal, but not the...

That looks like it would work for my use case. Would that complicate (or become complicated due to) https://github.com/cashapp/sqldelight/issues/1455?

Is there going to be a 1.5.4 release, or is 2.0 the next one coming out?