Henry Addo comments

Results 26 comments of


                                            Henry Addo

Missing Prougard rule

Thanks for confirming and considering it for inclusion in the next release.

Migrate java.io.File Usage to Kotlin Multiplatform-Compatible Abstraction

Did you have any library in mind for this? I see these `io` libraries are available for KMP. 1. [Okio](https://github.com/square/okio) 2. [korlibs](https://github.com/korlibs/korlibs) 3. [Suparnatural FS](https://github.com/suparngp/kotlin-multiplatform-projects/tree/master/fs) 4. [kotlinx-io](https://github.com/Kotlin/kotlinx-io) Which do you...

Migrate java.io.File Usage to Kotlin Multiplatform-Compatible Abstraction

@takahirom thanks for your quick response. Yeah I think so too, `kotlinx-io` is a good choice to go with as it's an official library by Jetbrains. My only issue it's...

Migrate java.io.File Usage to Kotlin Multiplatform-Compatible Abstraction

@takahirom I believe per @RyuNen344 comprehensive response, it's safe to say that we can use `kotlinx.io` as it has all that's needed for Roborazzi. Well, except for the fact that...

Replace `enum class ErrorType` by a sealed class to add properties to errors

@maxme is this up for grabs if so will be nice to flesh out a bit more or this sort of depends on the work needed by backend for #66...

Replace `enum class ErrorType` by a sealed class to add properties to errors

oh I was hoping to receive a response on it. If it's not ready then I'll wait.

Replace `enum class ErrorType` by a sealed class to add properties to errors

No worries. This is also not ready then. Thanks for confirming it.

API: `uploadImage` (and future private endpoints) onError callback should encapsulate the error message returned from the backend

@maxme I'm interested in picking this up of course if it's ready for grabs. I just need a little info on how you want this implemented. With support for passing...

API: `uploadImage` (and future private endpoints) onError callback should encapsulate the error message returned from the backend

I understand. It needs to be unblocked by backend work then. Thanks for the response.

fix(deps): update dependency org.webjars:webjars-locator-lite to v0.0.6

> remember this, do you have any reason why we use 0.0.4 instead of 0.0.6 of webjar-locator-lite? No reason. I didn't search to see if there was a newer version...