Eyal Ezer
Eyal Ezer
indeed missed one integration test and also i see now some format issues, will fix both
@mistercrunch - Fixed and tested locally both formats and integration tests
@mistercrunch Discovered additional instances throughout the system that are still uncovered... i'll create a new pr for those
@mistercrunch - tests from last commit https://github.com/apache/superset/pull/28486 still covers for the encoding part.
definitely felt the same seeing things being repeated more than once while dealing with this non UTF-8 bytes. for starters lets try to move all of those recent UTF-16 handling...
@mistercrunch - i've tried to keep it as small as possible for this first phase but it ended up with 30 files changed after all 😏 next phase (as mentioned)...
@mistercrunch - with pleasure. since i got my head into this I have begun working on the subsequent stage of the refactoring. It is likely that I will submit another...
@mistercrunch - here's the second part of the refactor, as expected this is a huge PR: 232 files changed
i'll rebase it quickly so it won't catch up more conflicts... regarding the linter, it's a great idea and it looks like it should be plausible by adding a custom...
@betodealmeida - awesome, so it's even easier than i thought... i'll look into it now and test it