Scott Dutton

Results 125 comments of Scott Dutton

Just tried the dev branch for this and it scans well! Great job @DrZlo13 and others involved

https://github.com/mauimauer/flipperzero-firmware/tree/fdxb

You can ignore every instance by using intval(10) instead of just 10. It's not ideal as you wouldn't know by looking at intval(10) that it's used to ignore a check...

Yeah agreed. I think the same about comments to ignore lines tbh. The array key whitelist is not a bad idea. There is also a check in phpmnd for numeric...

Does phpmnd stop working or just emit that as a warning ? Have you got a container you were working with ?

I will look at silencing that warning, as there is code to handle it not working. Thanks!

@sidz just updated this one too, shows 0755 as 0o755 now rather than 493

Not sure why appveyor is complaining. Will take a look later. Passes travis

This should be multilingual now.

>I don't think this tool can ever replace thorough code review, it can help, by ensuring there are constants for everything Completely agree. Since using this Ive seen more and...