Chris Oliver comments

Results 300 comments of


                                            Chris Oliver

Got error `ret: 2, hash modified during iteration` After upgrade ruby 2.7.0

Same error, mine happened in a different location: ``` /GEM_ROOT/gems/meta-tags-2.13.0/lib/meta_tags/renderer.rb:189 /GEM_ROOT/gems/meta-tags-2.13.0/lib/meta_tags/renderer.rb:189 /GEM_ROOT/gems/meta-tags-2.13.0/lib/meta_tags/renderer.rb:35 /GEM_ROOT/gems/meta-tags-2.13.0/lib/meta_tags/view_helper.rb:181 /GEM_ROOT/gems/meta-tags-2.13.0/lib/meta_tags/meta_tags_collection.rb:53 /GEM_ROOT/gems/meta-tags-2.13.0/lib/meta_tags/view_helper.rb:181 ```

Maintainer?

Bump @ctran

Adding sequential_id to has_one :through relation

@phylor Send over a PR and a test and I'll get it merged and released. I guess we'd want to account for possibly multiple join tables too?

Using this as-is in Rails 5.2.1 doesnt work

I've updated the test suite to test against Rails 5.2+ and all the tests are passing. Going to close this. If you can provide a test to reproduce the issue,...

Building scopes doesn't work with ActiveRecord enums

I've updated the test suite to run against Rails 5.2+ and Ruby 2.7+. I'm going to close this, but if anyone wants this picked up we can open a new...

[Example] Testing for multiple screen sizes

This is 🔥

[Example] Login with Devise

Add example for fixture passwords with Devise ```yaml default: email: [email protected] encrypted_password: ```

Add Madmin to list of admin interfaces

I'll be adding it to Jumpstart soon, so we should get to 20k pretty fast after that. 👍

Github Actions: "[error]Process completed with exit code 1."

Trying to test this locally. This is what I got: ```bash ± bundle config path vendor/bundle ± bundle exec appraisal true >> bundle check --gemfile='/Users/chris/code/acts_as_tenant/gemfiles/rails_5.gemfile' || bundle install --gemfile='/Users/chris/code/acts_as_tenant/gemfiles/rails_5.gemfile' --retry...

Github Actions: "[error]Process completed with exit code 1."

`exception: true` was added in Ruby 2.7 it looks like unfortunately. We can use popen3 that would be more compatible.